Repository navigation
ci: add a shellcheck check - #928
Open
solace-wkourlas wants to merge 1 commit into
Open
solace-wkourlas wants to merge 1 commit into
solace-wkourlas wants to merge 1 commit into
Conversation
solace-wkourlas
requested review from
sgamelin,
shortishly and
solace-aross
as code owners
October 9, 2026 21:51
solace-wkourlas
force-pushed
the
ci/shellcheck
branch
from
October 9, 2026 22:09
ce35d4f to
db92bd9
Compare
A new Tier A job runs shellcheck 0.11.0 on every shell script in the repository, and ci-gate requires it. actionlint already checks the shell in workflow run: blocks, so this job covers the standalone scripts. The same check runs locally with just shellcheck. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: William Kourlas <156007774+solace-wkourlas@users.noreply.github.com>
solace-wkourlas
force-pushed
the
ci/shellcheck
branch
from
October 9, 2026 22:11
db92bd9 to
729cb89
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes, and why?
A new Tier A
shellcheckjob runs shellcheck 0.11.0 on every tracked*.sh/*.bashscript.ci-gatelists it, so it gates merges without a ruleset change.actionlint already shellchecks the
run:blocks inside workflows, so this job covers the standalone scripts (todaycompat/*/run.sh,nisshi-smoke-test/run.shand.github/scripts/ci-changes*.sh). Liketypos, it does not depend onchanges, so it also runs on a PR that touches only CI config or prose. The version is pinned throughtaiki-e/install-actioninstead of taken from the runner image, so a runner image update cannot fail the check on unchanged code. The same check runs locally withjust shellcheck.Upgrade impact
None.
How was this tested?
ci.yml.🤖 Generated with Claude Code